Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply the LINCC Frameworks python project template #14

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Apply the LINCC Frameworks python project template #14

merged 2 commits into from
Oct 17, 2023

Conversation

delucchi-cmu
Copy link

This is a mostly mechanical hydration of the python project template.

There were the following manual adjustments:

  • removes setup.py and replaces with content in pyproject.toml
  • adds one new module for file io that has a single (simple) method to read a dict from json.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

OliviaLynn
OliviaLynn approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@OliviaLynn OliviaLynn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the only failing test is isort on the precommit hook, so I'd say this looks good!

I added a commit to remove duplicate workflow_dispatch lines (and opened a PR in the template for it as well).

.copier-answers.yml Show resolved Hide resolved
grantmerz
grantmerz approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@grantmerz grantmerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@delucchi-cmu delucchi-cmu merged commit 30a3e4a into main Oct 17, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantmerz grantmerz grantmerz approved these changes

@OliviaLynn OliviaLynn OliviaLynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delucchi-cmu @OliviaLynn @grantmerz